Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search compiler-specific fpm builds #38

Merged
merged 6 commits into from
Mar 10, 2025
Merged

Search compiler-specific fpm builds #38

merged 6 commits into from
Mar 10, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Mar 10, 2025

Attempt to fix #37 fortran-lang/fpm#1104

fpm release assets were changed naming in fortran-lang/fpm#985.

@gnikit should we bump the release version after this? Otherwise, people won't be able to use fpm 0.11.0 and in general those using latest wuold break their CIs.

perazz added 3 commits March 10, 2025 17:01

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@perazz perazz requested a review from gnikit March 10, 2025 16:06
@certik
Copy link
Member

certik commented Mar 10, 2025

Yes, make a new release of setup-fpm. So that the last version works with fpm < 0.11.0 and the new version with fpm >= 0.11.0. Document this in the README.

@certik
Copy link
Member

certik commented Mar 10, 2025

Also, very important: allow setup-fpm to select an exact version of fpm, and make that the default main example in the README. People should have been using that already, that way things will not break like this.

@certik
Copy link
Member

certik commented Mar 10, 2025

Goal: a specific version of setup-fpm and fpm together should never break at the CI.

We can do backwards incompatible changes, and users can manually upgrade both setup-fpm and fpm to compatible "combo" versions. That's fine.

@perazz
Copy link
Member Author

perazz commented Mar 10, 2025

right now the default version is latest which I think will always break something in the long run. So maybe each setup-fpm version should instead have a default fpm version it works well with? Then we should make a table in README that shows the default fpm version for each version of the action?

perazz added 3 commits March 10, 2025 17:48
@perazz
Copy link
Member Author

perazz commented Mar 10, 2025

Thank you @gnikit @certik, merging.

@perazz perazz merged commit 597c61f into main Mar 10, 2025
12 checks passed
@perazz perazz deleted the fix_gcc_extensions branch March 10, 2025 17:16
@certik
Copy link
Member

certik commented Mar 10, 2025

Yes exactly --- default version by default, and users can override it manually. Then things should never break on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken with new version fpm 0.11.0?
2 participants