Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/types resolution (#179) #180

Merged
merged 9 commits into from
Apr 16, 2024
Merged

Fix/types resolution (#179) #180

merged 9 commits into from
Apr 16, 2024

Conversation

bornova
Copy link
Contributor

@bornova bornova commented Apr 12, 2024 •
edited

Included in the PR:

  • Fixes the types resolution for dual exports by generating separate definition files for .cjs and .mjs files. New definition files are types/cjs/index.d.cts and types/esm/index.d.mts respectively. Fixes Add a fix for types resolution  #179
  • Updated dependencies
    • Eslint 9.0 uses flat config file, so introducing eslint.config.js and removing .eslintrc and .eslintignore
  • Clean up unused eslint rules

Note: This will drop support for Node10 which reached EOL in 4/2021

@nicolashefti nicolashefti self-requested a review April 15, 2024 18:38
@nicolashefti nicolashefti added bug Something isn't working enhancement New feature or request labels Apr 15, 2024
nicolashefti
nicolashefti requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@nicolashefti nicolashefti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me. Just a little clean up in the package.json.

package.json Outdated Show resolved Hide resolved
@nicolashefti nicolashefti merged commit 7d3fa99 into master Apr 16, 2024
1 check passed
@nicolashefti nicolashefti deleted the fix/types-resolution branch April 16, 2024 08:35
@magJ magJ mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolashefti nicolashefti nicolashefti approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a fix for types resolution
2 participants
@bornova @nicolashefti