Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indicatif 0.17.4 breaks rendering #706

Closed
foresterre opened this issue Jun 2, 2023 · 1 comment
Closed

indicatif 0.17.4 breaks rendering #706

foresterre opened this issue Jun 2, 2023 · 1 comment

Comments

@foresterre
Copy link
Owner

foresterre commented Jun 2, 2023

❯ cargo msrv
  [Meta]   cargo-msrv 0.16.0-beta.14

Compatibility Check #1: Rust 1.51.0
◓                  Elapsed 0s
◓ Rust 1.51.0      Elapsed 6s
❯ cargo msrv
  [Meta]   cargo-msrv 0.16.0-beta.14

Compatibility Check #1: Rust 1.51.0
◓                  Elapsed 0s
  [FAIL]   Is incompatible

  ╭───────────────────────────────────────────────────────────────────────────────────────╮
  │ warning: `rust-version` is not supported on this version of Cargo and will be ignored │
  │                                                                                       │
  │ this Cargo does not support nightly features, but if you                              │
  │ switch to nightly channel you can add                                                 │
  │ `cargo-features = ["rust-version"]` to enable this feature                            │
  │     Updating crates.io index                                                          │
  │ error: failed to select a version for the requirement `clap = "=4.1.10"`              │
  │ candidate versions found which didn't match: 3.2.25, 3.2.24, 3.2.23, ...              │
  │ location searched: crates.io index                                                    │
  │ required by package `cargo-msrv v0.16.0-beta.8 (/home/foresterre/cargo-msrv)`      │
  │                                                                                       │
  ╰───────────────────────────────────────────────────────────────────────────────────────╯


Compatibility Check #2: Rust 1.61.0
❯ cargo msrv
  [Meta]   cargo-msrv 0.16.0-beta.14

Compatibility Check #1: Rust 1.51.0
◓                  Elapsed 0s
  [FAIL]   Is incompatible

  ╭───────────────────────────────────────────────────────────────────────────────────────╮
  │ warning: `rust-version` is not supported on this version of Cargo and will be ignored │
  │                                                                                       │
  │ this Cargo does not support nightly features, but if you                              │
  │ switch to nightly channel you can add                                                 │
  │ `cargo-features = ["rust-version"]` to enable this feature                            │
  │     Updating crates.io index                                                          │
  │ error: failed to select a version for the requirement `clap = "=4.1.10"`              │
  │ candidate versions found which didn't match: 3.2.25, 3.2.24, 3.2.23, ...              │
  │ location searched: crates.io index                                                    │
  │ required by package `cargo-msrv v0.16.0-beta.8 (/home/foresterre/cargo-msrv)`      │
  │                                                                                       │
  ╰───────────────────────────────────────────────────────────────────────────────────────╯


Compatibility Check #2: Rust 1.61.0
[1]    7914 killed     cargo msrv

windows:

  [Meta]   cargo-msrv 0.16.0-beta.14

Compatibility Check #1: Rust 1.51.0
◓                  Elapsed 0s
  [FAIL]   Is incompatible

  ╭───────────────────────────────────────────────────────────────────────────────────────╮
  │ warning: `rust-version` is not supported on this version of Cargo and will be ignored │
  │                                                                                       │
  │ this Cargo does not support nightly features, but if you                              │
  │ switch to nightly channel you can add                                                 │
  │ `cargo-features = ["rust-version"]` to enable this feature                            │
  │     Updating crates.io index                                                          │
  │ error: failed to select a version for the requirement `clap = "=4.3.0"`               │
  │ candidate versions found which didn't match: 3.2.25, 3.2.24, 3.2.23, ...              │
  │ location searched: crates.io index                                                    │
  │ required by package `cargo-msrv v0.16.0-beta.14 (C:\Marwen\ws\cargo-msrv)`            │
  │                                                                                       │
  ╰───────────────────────────────────────────────────────────────────────────────────────╯


Compatibility Check #2: Rust 1.61.0
memory allocation of 17448304640 bytes failed

present in:

  • latest git
  • beta.14
  • beta.13
  • beta.12
  • beta.10

unable to check: beta's before at least beta.7 when installed via cargo install cargo-msrv version, because of vergen lacking repo data.

Could also be windows-terminal (first printed output above is from ubuntu via windows-terminal, last one is pwsh7 via windows-terminal); I've not observed this issue before. I did recently update windows terminal. Also reproduce in cmd

This is probably the Rust compilers fault (1.70) or a dependency.

  • Running with --output-format json works as intended.
  • cargo binstall cargo-msrv cargo-msrv --version 0.16.0-beta.14 --force: works as intended
  • cargo install cargo-msrv --version 0.16.0-beta.14 --force --no-default-features --locked: works as intended
  • setting indicatif = "=0.17.3" in the manifest, and recompiling cargo install cargo-msrv --path . --force: works as intended

Issue is almost certainly caused by the upgrade from 0.17.3 to 0.17.4. Since this is a patch release, it would also fail for older beta builds, since I wasn't using --locked.

@foresterre foresterre changed the title beta.14 display issue indicatif to 0.17.4 breaks rendering Jun 2, 2023
@foresterre foresterre changed the title indicatif to 0.17.4 breaks rendering indicatif 0.17.4 breaks rendering Jun 2, 2023
@foresterre
Copy link
Owner Author

foresterre commented Jun 2, 2023

I opened an issue at the indicatif repo: console-rs/indicatif#546
I also opened an attempt at a fix: console-rs/indicatif#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant