Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define workflow for verifying MSRV for [lib]s where version reqs support a range of MSRV #312

Open
epage opened this issue Feb 22, 2022 · 1 comment

Comments

@epage
Copy link

epage commented Feb 22, 2022

[lib]-only crates generally do not maintain a Cargo.lock file which makes verifying MSRV difficult because a dependency version requirement might cover a range of MSRVs.

Case studies

As far as I'm aware, the only solution I know for this is to keep a Cargo.lock.msrv and to copy it over in CI. cargo-msrv verify natively recognizing this pattern and documenting it would be one solution.

The ideal long term solutions are

  • -Z minimal-versions that only does minimal versions for direct dependencies (see ehuss's comment) (only a partial solution)
  • Cargo's resolver to take MSRV into account

(somewhat related to #117)

@foresterre
Copy link
Owner

Excellent suggestion, thanks for opening an issue!
I'll have a proper look at this soon.

@foresterre foresterre added this to the v0.16.0 milestone Mar 8, 2022
@foresterre foresterre modified the milestones: v0.16.0, v0.17.0 Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants