fix the order of prune_unused_regions #3268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be after each vardata optimization.
Here's a testcase, I used this command
fonttools varLib.instancer --no-overlap-flag --no-recalc-timestamp --no-optimize --output=ft.ttf test/subset/data/fonts/NotoSans-VF.abc.ttf wght=200:600 wdth=80:90 CTGR=20:60
File used is this: https://github.com/harfbuzz/harfbuzz/blob/main/test/subset/data/fonts/NotoSans-VF.abc.ttf
And generated MVAR table is like below:
2 regions indexed at 1 and 2 are not used and not pruned.
This PR will fix it.