Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for merging of NULL anchors #3248

Merged
merged 2 commits into from Aug 7, 2023
Merged

Allow for merging of NULL anchors #3248

merged 2 commits into from Aug 7, 2023

Conversation

simoncozens
Copy link
Collaborator

anthrotype
anthrotype approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simoncozens simoncozens merged commit 57fb47d into main Aug 7, 2023
10 checks passed
@simoncozens simoncozens deleted the merge-null-anchors branch August 7, 2023 16:12
@behdad
Copy link
Member

behdad commented Aug 7, 2023

Oops. Thanks Simon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[merger] Cursive attachment merging fails when all anchors are NULL
3 participants
@simoncozens @behdad @anthrotype