New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[merger] Cursive attachment merging fails when all anchors are NULL #3247
Comments
is this perhaps a regression introduced with #3209 three weeks ago? |
how does one reproduces exactly? could you push a failing test case in varLib/merger_test.py so Behdad can fix it |
Will do. I could probably fix it myself, TBH; it just needs a custom merger for EntryAnchor/ExitAnchors. |
simoncozens
added a commit
that referenced
this issue
Aug 7, 2023
simoncozens
added a commit
that referenced
this issue
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Carried over from googlefonts/fontmake#1022.
When all anchors in all masters are of the form:
the merger creates an ExitEntryAnchor like this:
This means that deep inside
mergeThings
, when trying to merge the entry anchors, we hit this code path:All entry anchors are None, but the target entry anchor is an
Anchor
so merging fails.The text was updated successfully, but these errors were encountered: