Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse cff2 #3234

Merged
merged 3 commits into from Aug 2, 2023
Merged

Sparse cff2 #3234

merged 3 commits into from Aug 2, 2023

Conversation

behdad
Copy link
Member

@behdad behdad commented Aug 1, 2023

Fixes #3233

@behdad
Copy link
Member Author

behdad commented Aug 1, 2023

Ignore the first commit. I pushed it to main now.

@behdad behdad force-pushed the sparse-cff2 branch 4 times, most recently from 575ddb8 to e375827 Compare August 1, 2023 17:20
@behdad
Copy link
Member Author

behdad commented Aug 1, 2023

Okay now only test_varlib_build_sparse_CFF2 test failes, which might need new expectations.

@behdad
Copy link
Member Author

behdad commented Aug 1, 2023

Tests pass now.

@behdad behdad force-pushed the sparse-cff2 branch 2 times, most recently from 7b14708 to 9590808 Compare August 1, 2023 17:25
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll push a test after lunch

…ster

Three masters, Regular and Bold have glyphs .notdef, a, e; Medium only has .notdef (but empty, no contours) and e.
@anthrotype anthrotype merged commit ac9421d into main Aug 2, 2023
10 checks passed
@anthrotype anthrotype deleted the sparse-cff2 branch August 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFF2: interpret empty glyphs from non-default sparse master as missing, like with gvar
2 participants