Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subset] Revert use of NameVisitor to fix speed regression #3214

Merged
merged 2 commits into from Jul 20, 2023
Merged

[subset] Revert use of NameVisitor to fix speed regression #3214

merged 2 commits into from Jul 20, 2023

Conversation

anthrotype
Copy link
Member

Fixes #3213

@anthrotype
[subset] Revert use of NameVisitor in subsetter which may be causing …
f0d601a 
…speed regression

Intended to fix #3213

Revert "Implement Cosimo feedback"

This reverts commit cfede76.

Revert "remove redundant CPAL name removal code"

This reverts commit b563941.

Revert "convert name table _prune_pre_subset to prune_post_subset"

This reverts commit 0a6e8bf.

Revert "Use NameRecordVisitor in subsetter"

This reverts commit edf8891.
@anthrotype
[NameVisitor] remove logging, caller can log if they wish
687e23c
@anthrotype
Copy link
Member Author

@imran-iq @satbyy could you please try to install fonttools from this PR branch and see if that fixes the speed regression you experienced?

pip install -e git+https://github.com/fonttools/fonttools.git@subset-speed-regression#egg=FontTools

@imran-iq
Copy link

I can confirm that running temporal_font.sh (from the linked issue) with the above pip install works (ie doesnt take a long time)

@anthrotype anthrotype requested a review from behdad July 20, 2023 14:31
@imran-iq imran-iq mentioned this pull request Jul 20, 2023
Closed
@behdad
Copy link
Member

behdad commented Jul 20, 2023

Lgtm. Unfortunate. cc @m4rc1e.

@anthrotype anthrotype merged commit f7965ba into main Jul 20, 2023
10 checks passed
@anthrotype anthrotype deleted the subset-speed-regression branch July 20, 2023 14:34
@m4rc1e
Copy link
Contributor

m4rc1e commented Jul 20, 2023

Thanks for just removing it from the subsetter only.

behdad added a commit that referenced this pull request Jul 20, 2023
@behdad
Revert "Merge pull request #3214 from fonttools/subset-speed-regression"
4bfa731 
This reverts commit f7965ba, reversing
changes made to 31319a7.
behdad added a commit that referenced this pull request Jul 20, 2023
@behdad
Revert "Merge pull request #3214 from fonttools/subset-speed-regression"
d27cc3a 
This reverts commit f7965ba, reversing
changes made to 31319a7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behdad behdad Awaiting requested review from behdad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance regression in 4.41.0?
4 participants
@anthrotype @imran-iq @behdad @m4rc1e