Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[instancer] Allow null ConditionSet #3212

Merged
merged 2 commits into from Jul 20, 2023
Merged

[instancer] Allow null ConditionSet #3212

merged 2 commits into from Jul 20, 2023

Conversation

behdad
Copy link
Member

@behdad behdad commented Jul 19, 2023

Fixes #3211

@behdad behdad requested a review from anthrotype July 19, 2023 19:31
@behdad behdad force-pushed the instancer-null-conditionset branch from 4457995 to 0e4cff8 Compare July 19, 2023 19:43
@behdad behdad force-pushed the instancer-null-conditionset branch from 0e4cff8 to b0cf3e1 Compare July 20, 2023 01:55
anthrotype
anthrotype approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@behdad behdad merged commit 31319a7 into main Jul 20, 2023
10 checks passed
@behdad behdad deleted the instancer-null-conditionset branch July 20, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FeatureVariationRecord with no condition set causes error
2 participants
@behdad @anthrotype