Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FontBuilder] Update setupAvar() to also support avar-2, fixing _add_avar() call site #3183

Merged
merged 3 commits into from Jun 25, 2023

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Jun 25, 2023

Fixes #3182.

The avar-2 bit is untested, but I did add a minimal FontBuilder avar test that would have caught #3182.

@behdad
Copy link
Member

behdad commented Jun 25, 2023

LGTM. Sorry about the breakage.

@justvanrossum justvanrossum merged commit 44cfe35 into main Jun 25, 2023
10 checks passed
@justvanrossum justvanrossum deleted the issue3182 branch June 25, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FontBuilder] _add_avar() is called with the wrong amounts of arguments
2 participants