Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voltLib.voltToFea module and command line tool #3164

Merged
merged 2 commits into from Jun 16, 2023
Merged

Add voltLib.voltToFea module and command line tool #3164

merged 2 commits into from Jun 16, 2023

Conversation

khaledhosny
Copy link
Collaborator

A tool for converting VOLT VTP projects to feature files.

Essentially https://github.com/TiroTypeworks/TiroTools/tree/master/Volto with minor modifications to fit into FontTools.

A tool for converting VOLT VTP projects to feature files.

Essentially https://github.com/TiroTypeworks/TiroTools/tree/master/Volto
with minor modifications to fit into FontTools.
@behdad
Copy link
Member

behdad commented Jun 14, 2023

Maybe a more descriptive name?

@khaledhosny
Copy link
Collaborator Author

I have no particular attachment to the name, but it is the name used over at https://github.com/TiroTypeworks/TiroTools

@anthrotype
Copy link
Member

how about moving it inside voltLib and renaming the module voltToFea, like the class is also called?

@khaledhosny
Copy link
Collaborator Author

At one point it was supposed to grow a fea to volt convertor as well, and may be even a volt compiler. This didn’t happen though, and no idea if it ever will.

@anthrotype
Copy link
Member

We could add more submodules if/when needed. I think having a both a fontTools.voltLib and fontTools.volto is confusing and one "volt" too much for the top level modules.

@khaledhosny
Copy link
Collaborator Author

We could add more submodules if/when needed. I think having a both a fontTools.voltLib and fontTools.volto is confusing and one "volt" too much for the top level modules.

Done.

@khaledhosny khaledhosny changed the title Add Volto Add voltLib.voltToFea module and command line tool Jun 14, 2023
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks to Khaled and TiroTypeworks for contributing this to fonttools!

@khaledhosny khaledhosny merged commit 060b5f3 into main Jun 16, 2023
10 checks passed
@khaledhosny khaledhosny deleted the volto branch June 16, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants