implied oncurve points for interpolatable glyphs #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it can be used by client code on multiple glyf Glyph objects regardles of TTGlyphPen
anthrotype
force-pushed
the
drop-implied-oncurves-interpolatable
branch
from
3b80834
to
a039e1d
Compare
|
LGTM. Thanks! |
behdad
approved these changes
Jun 1, 2023
This was referenced Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a drop_implied_oncurves function inside ttGlyphPen, but that being a pen only works for a single glyph.
Thus I modified this to work on one or more (interpolatable) glyphs and to only prune oncurve points that are impliable for all of the input glyphs, such that the modified glyphs maintain interpolability.
I also moved it to the glyf table module. I'd like to use this in ufo2ft to massage the glyphs of master TTFs before it calls varLib.build.
fontc does a similarly eager pruning of oncurve points and I'd like to have this done (optionally) in fontmake-py as well.