[feaLib] Support variable ligature caret position #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
force-pushed
the
fealib-ligcaret-variable
branch
from
f7db6e1
to
8f4f817
Compare
khaledhosny
force-pushed
the
fealib-ligcaret-variable
branch
from
9d38952
to
1aba6e4
Compare
anthrotype
reviewed
May 30, 2023
anthrotype
reviewed
May 30, 2023
Allow variable scaler in ligature caret position and build CaretValueFormat3 with DeviceTable. Does not support non-variable device table, but can be added if someone really really wants it.
khaledhosny
force-pushed
the
fealib-ligcaret-variable
branch
from
1aba6e4
to
a43f824
Compare
anthrotype
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow variable scaler in ligature caret position and build CaretValueFormat3 with DeviceTable. Does not support non-variable device table, but can be added if someone really really wants it.