Var store optimize more #3127
Merged
Var store optimize more #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very unlikely that this path is needed, but it's correct to have it.
See comments. Produces better results.
Produces better results even.
behdad
force-pushed
the
varStore-optimize-more
branch
from
09e7845
to
f12f3d8
Compare
behdad
force-pushed
the
varStore-optimize-more
branch
from
5f64f1a
to
9cbde09
Compare
behdad
force-pushed
the
varStore-optimize-more
branch
from
6fa38e2
to
d8fabfa
Compare
|
I'm happy with this code now. It was due for a refresh! |
behdad
force-pushed
the
varStore-optimize-more
branch
from
38a93e4
to
f5e62a1
Compare
cmyr
approved these changes
May 25, 2023
Lib/fontTools/varLib/varStore.py
Outdated
| best_idx = i | ||
| best_gain = combined_gain - separate_gain | ||
| heap = [] | ||
| for i, other_encoding in enumerate(todo): |
There was a problem hiding this comment.
i'm confused here, are we ever using other_encoding? it looks like we rebind it in the next loop without having touched it. Maybe it was supposed to be encoding, and then you wouldn't need to manually bind that, below?
Harmless thinko.
Honestly not much. In the few kilobytes range. For NotoSans-VF it's 10kb; Roboto-Flex it's 14kb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.