Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontBuilder: add glyphDataFormat=0; error with accidentally cubic outlines #3119

Merged
merged 4 commits into from May 23, 2023

Conversation

anthrotype
Copy link
Member

Fixes #3113

If one is certain that the glyph data has compatible format and prefers not to wait for each glyph flag to checked...
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I don't quite understand the use for the checkFormat argument.

@anthrotype
Copy link
Member Author

I don't quite understand the use for the checkFormat argument.

Initially I didn't have that, but then I thought that checking all glyf glyph flags may be relatively expensive operation to be doing all the time and if a client knows that all the glyphs that are passed to the fontBuilder have already been cu2qu'ed beforehand.. it's just a waste of time.

@justvanrossum
Copy link
Collaborator

Initially I didn't have that, but then I thought that checking all glyf glyph flags may be relatively expensive operation to be doing all the time and if a client knows that all the glyphs that are passed to the fontBuilder have already been cu2qu'ed beforehand.. it's just a waste of time.

Ahh, that makes a lot of sense. Maybe reword the doc string to make it clearer that that is what it's for? And/or consider calling it validateGlyphFormat? (Or anything else with the word validate in it.)

@anthrotype
Copy link
Member Author

anthrotype commented May 23, 2023

ok, will do Done

@anthrotype anthrotype merged commit 77a35fe into main May 23, 2023
10 checks passed
@anthrotype anthrotype deleted the glyph-data-format-option branch May 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the upcoming glyf table with cubics opt-in, behind a flag
2 participants