Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort translations after filtering them out. #695

Merged
merged 4 commits into from Dec 30, 2022
Merged

Sort translations after filtering them out. #695

merged 4 commits into from Dec 30, 2022

Conversation

fnando
Copy link
Owner

@fnando fnando commented Dec 30, 2022

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller
    PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into
    two PRs otherwise).
  • This PR's title starts is concise and descriptive.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or
    fixes.
  • I've updated any docs, .md files, etc… affected by this change.

What

Deep sort translations after filtering them out.

Why

This is one of the advertised features of v4, but turns I never actually implemented it.

Close #691.

Known limitations

Given this is a built-in behaviour, it can't be disabled nor replaced.

@fnando fnando merged commit 09fe978 into main Dec 30, 2022
@fnando fnando deleted the deep-sort-hashes branch December 30, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: deep sorting for keys missed
1 participant