Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid rewriting exported JSON localizaton files if identical #694

Merged
merged 1 commit into from Dec 30, 2022
Merged

feat: avoid rewriting exported JSON localizaton files if identical #694

merged 1 commit into from Dec 30, 2022

Conversation

oleksii-leonov
Copy link
Contributor

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller
    PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into
    two PRs otherwise).
  • This PR's title starts is concise and descriptive.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or
    fixes.
  • I've updated any docs, .md files, etc… affected by this change.

What

Fixes #693.

Running i18n export should not rewrite exported JSON localization files if the content hasn't changed.
In v3, it was fixed in #473.

Why

Fixes #693.

Known limitations

N/A

@fnando fnando merged commit d2e0170 into fnando:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnando fnando fnando approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: overwriting identical exported JSON localization files
2 participants
@oleksii-leonov @fnando