support string evaluation in CEL expressions #882
Merged
+153
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathleenfrench
force-pushed
the
kfrench/cel-eval-string
branch
from
664e3fe to
ca33616
Compare
matheuscscp
reviewed
Mar 11, 2025
There was a problem hiding this comment.
@kathleenfrench Really glad to see a contribution in this lib I created recently, thanks very much! 😁
kathleenfrench
force-pushed
the
kfrench/cel-eval-string
branch
2 times, most recently
from
5985a90 to
f7bee61
Compare
matheuscscp
approved these changes
Mar 11, 2025
kathleenfrench
force-pushed
the
kfrench/cel-eval-string
branch
2 times, most recently
from
b6087da to
38d4153
Compare
|
@kathleenfrench Please revert the quote change and squash into a single commit 🙏 |
Signed-off-by: kathleen french <kfrench@groq.com>
kathleenfrench
force-pushed
the
kfrench/cel-eval-string
branch
from
38d4153 to
567773d
Compare
|
@kathleenfrench I pushed the tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: fluxcd/notification-controller#589 (comment)
in order to leverage the
celflux package for the purposes of evaluating a commit status/id expression, it's necessary to expose a function for evaluating strings (similar toEvaluateBoolean)