Add nop logger #3198
Merged
Add nop logger #3198
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/log/log.go
Outdated
| @@ -30,3 +30,17 @@ type Logger interface { | |||
| // Failuref logs a formatted failure message. | |||
| Failuref(format string, a ...interface{}) | |||
| } | |||
|
|
|||
| type DiscardLogger struct{} | |||
There was a problem hiding this comment.
Please move this to a new file e.g. nop.go and rename the type to NopLogger like zap does.
There was a problem hiding this comment.
Wouldn't simply log.Discard make more sense?
There was a problem hiding this comment.
My above comment wasn't taken into account when this was merged.
phillebaba
force-pushed
the
discard-logger
branch
from
703fee2 to
5948b1c
Compare
hiddeco
reviewed
Oct 12, 2022
phillebaba
force-pushed
the
discard-logger
branch
from
5948b1c to
9460dfe
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
discard-logger
branch
from
9460dfe to
f6c96ae
Compare
stefanprodan
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a discard implementation of the logger interface which is useful for testing purposes.