Move uninstall code to pkg #3197
Merged
+346
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
move-uninstall
branch
from
b3589ec to
f6a3bf0
Compare
hiddeco
reviewed
Oct 12, 2022
hiddeco
reviewed
Oct 12, 2022
hiddeco
reviewed
Oct 12, 2022
hiddeco
reviewed
Oct 12, 2022
|
Same suggestions apply for the other functions. |
phillebaba
force-pushed
the
move-uninstall
branch
2 times, most recently
from
cb87c60 to
df3391e
Compare
|
@hiddeco I agree that removing the |
|
One additional nit (other than that absolutely perfect): given things move into the public API, it would probably be good to document the (behavior) of the functionalities. Both because of consumer ease, and ensuring the behavior stays the same in terms of backwards compatibility. |
phillebaba
force-pushed
the
move-uninstall
branch
from
df3391e to
47b304b
Compare
Signed-off-by: Philip Laine <philip.laine@gmail.com>
phillebaba
force-pushed
the
move-uninstall
branch
from
47b304b to
80b8772
Compare
hiddeco
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the uninstall logic from
cmdtopkg. This is done so that it can be shared with the Terraform Provider reducing the need to duplicate code.