Github action labeller keeps removing labels

[Piinks]

Related to #126002

The new github action that manages labels in flutter/flutter keeps removing labels applied by team members.
Example - the docs labels were removed from this PR:

#127904

[Piinks]

cc @CaseyHillers

[CaseyHillers]

By default, https://github.com/actions/labeler#inputs indicates this shouldn't happen. I'm debugging the action to see why it would remove those labels.

[Piinks]

Just saw this still happening on #128756

[Piinks]

Noticed again in #129433

[CaseyHillers]

\cc @christopherfujino

I thought this would get auto-resolved as it had a fix in the upstream, but it looks like it was reverted in actions/labeler#564.

It was pushed to v5.0.0-beta.1 branch, but that branch had some runtime issues that required us to revert.

[christopherfujino]

@CaseyHillers overall has it been worth the instability and lack of control to migrate from handling GitHub webhooks in cocoon to using the labeler action? Where there other constraints motivated the migration?

[CaseyHillers]

@CaseyHillers overall has it been worth the instability and lack of control to migrate from handling GitHub webhooks in cocoon to using the labeler action? Where there other constraints motivated the migration?

Generally, as long as this is off the core cocoon service, infra is happy. I took this as an opportunity to experiment with GitHub actions and see if other infra logic could benefit. And the tl;dr is I don't think we should move forward with GitHub actions (lack of presubmit testing being the largest factor).

As for the labeler action, I'm curious if #130642 fixes the issue with labels being removed. If there's other issues, please let me know. AFAIK that's the only issue.

[CaseyHillers]

I skimmed framework PRs for the last week and can't seem to any instances where this is happening. @Piinks is this still reproducing for you?

[Piinks]

I have not seen it happen, thank you @CaseyHillers! Closing as fixed. 😀

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

[Piinks]

Re-opening because I saw this today on #143979

Not critical, but it is kind of amusing. :)

[CaseyHillers]

As a retrospective, we should add back the Dart code. However, update it to read the .github/labeler.yml file for the rules.

[keyonghan]

Let's keep monitoring a bit.