Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildroot "scorecard" action is failing on not valid SARIF #127598

Closed
gaaclarke opened this issue May 25, 2023 · 3 comments
Closed

buildroot "scorecard" action is failing on not valid SARIF #127598

gaaclarke opened this issue May 25, 2023 · 3 comments
Labels
engine flutter/engine repository. See also e: labels.

Comments

@gaaclarke
Copy link
Member

gaaclarke commented May 25, 2023

example: https://github.com/flutter/buildroot/actions/runs/5082436625

log

Uploading results
Error details: instance.runs[0].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error details: instance.runs[2].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error details: instance.runs[2].results[1].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error details: instance.runs[2].results[2].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error details: instance.runs[2].results[3].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error: Unable to upload "results.sarif" as it is not valid SARIF:
- instance.runs[0].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[1].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[2].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[3].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
Error: Unable to upload "results.sarif" as it is not valid SARIF:
- instance.runs[0].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[0].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[1].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[2].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format
- instance.runs[2].results[3].locations[0].physicalLocation.artifactLocation.uri does not conform to the "uri-reference" format

cc @sealesj

@gaaclarke gaaclarke added the engine flutter/engine repository. See also e: labels. label May 25, 2023
@drewroengoogle
Copy link
Contributor

drewroengoogle commented May 25, 2023

It seems like flutter/buildroot@42583ce is the culprit here based on the commit message:

Updated the SARIF 2.1.0 JSON schema file to the latest from https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json

There is a bug filed with the scorecards team (ossf/scorecard#3063) which caused the filing of github/codeql-action#1703.

Short term, does it make sense to roll back to 2.3.3 and then have dependabot ignore 2.3.4?

@drewroengoogle
Copy link
Contributor

I reverted the patch to codeql-action and blocked 2.3.4 from being automatically updated again by dependabot. Closing

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

No branches or pull requests

2 participants