Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jruby] avoid using deprecated BigDecimal.new #546

Merged
merged 1 commit into from Oct 18, 2023
Merged

[jruby] avoid using deprecated BigDecimal.new #546

merged 1 commit into from Oct 18, 2023

Conversation

kares
Copy link
Contributor

@kares kares commented Oct 15, 2023 •
edited

an alternative PR to: #543 - for the BigDecimal case it should behave the same

main difference is that a custom opts[:decimal_class] (e.g. a BigDecimal sub-class) should work as before...

not sure decimal_class feature is used much or that folks would set it to anything different than BigDecimal but at least the pure.rb seems to retain a similar logic

@kares kares mentioned this pull request Oct 15, 2023
Closed
@hsbt hsbt merged commit 5c9d9f5 into flori:master Oct 18, 2023
65 checks passed
@kares kares deleted the jruby-decimal-2 branch October 18, 2023 08:00
@headius
Copy link
Contributor

headius commented Oct 31, 2023

Looking forward to a release of this so we can close the relevant bugs in JRuby: jruby/jruby#7752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kares @headius @hsbt