Add a strict option to Generator
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior of calling `to_json` or even `to_s` on unsupported object is problematic in many cases. ``` >> JSON.parse(JSON.dump(Object.new)) => "#<Object:0x00000001034d8420>" ``` In some cases like blind serailization into some kind of store, you may want to assert that `JSON.parse(JSON.dump(obj)) == obj`. The `strict` option is a way to ensure this by rejecting any type that doesn't map cleanly to a JSON native type.
|
@casperisfine Thank you. I picked your commit and fixed conflict with #525 |
eregon
reviewed
May 9, 2024
Comment on lines
+344
to
+346
| if state.strict? | ||
| raise GeneratorError, "#{value.class} not allowed in JSON" | ||
| elsif value.respond_to?(:to_json) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior of calling
to_jsonor evento_son unsupported object is problematic in many cases.In some cases like blind serailization into some kind of store, you may want to assert that
JSON.parse(JSON.dump(obj)) == obj.The
strictoption is a way to ensure this by rejecting any type that doesn't map cleanly to a JSON native type.