Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM-66: Allow for deeper nested relations in the attribute list #2671

Merged
merged 14 commits into from
Apr 30, 2021

Conversation

geertplaisier
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #2671 (09c7a62) into master (f31b031) will increase coverage by 0%.
The diff coverage is 42%.

❗ Current head 09c7a62 differs from pull request most recent head b847f82. Consider uploading reports for the commit b847f82 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2671   +/-   ##
======================================
  Coverage      44%     44%           
======================================
  Files         184     183    -1     
  Lines        5748    5797   +49     
  Branches      747     754    +7     
======================================
+ Hits         2560    2588   +28     
- Misses       3050    3071   +21     
  Partials      138     138           
Flag Coverage Δ
frontend 44% <42%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...utelist/attribute-list/attribute-list.component.ts 47% <0%> (ø)
...ributelist/helpers/attribute-list-filter.helper.ts 18% <0%> (+7%) ⬆️
...terface/attributelist/helpers/statistics-helper.ts 47% <0%> (ø)
...ributelist/services/attribute-list-data.service.ts 38% <0%> (ø)
...butelist/services/attribute-list-export.service.ts 46% <ø> (ø)
...face/attributelist/state/attribute-list.actions.ts 100% <ø> (ø)
...utelist/services/attribute-list-manager.service.ts 27% <13%> (-2%) ⬇️
...face/attributelist/state/attribute-list.reducer.ts 35% <17%> (-2%) ⬇️
...ce/attributelist/state/attribute-list.selectors.ts 48% <38%> (-1%) ⬇️
...ibute-list-table/attribute-list-table.component.ts 46% <47%> (+<1%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f31b031...b847f82. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@mtoonen mtoonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtoonen mtoonen merged commit 9260c95 into master Apr 30, 2021
@mtoonen mtoonen deleted the dev/TM-66_Nested_relation_state_changes branch April 30, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants