Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BeforeValidException message for decode #526

Merged
merged 1 commit into from Jul 14, 2023
Merged

fix: BeforeValidException message for decode #526

merged 1 commit into from Jul 14, 2023

Conversation

vishwarajanand
Copy link
Collaborator

@vishwarajanand vishwarajanand commented Jul 14, 2023 •
edited by bshaffer

Addresses #514

BEGIN_COMMIT_OVERRIDE
fix: different BeforeValidException messages for nbf and iat (#526)
END_COMMIT_OVERRIDE

@vishwarajanand vishwarajanand marked this pull request as ready for review July 14, 2023 14:16
@bshaffer
Copy link
Collaborator

bshaffer commented Jul 14, 2023 •
edited

@vishwarajanand as there is no "bug" here, this should be considered a "chore" instead of a "fix"

Now I see that this is to differentiate between iat and nbf, not just to add a better exception message. My mistake, I agree now that it is a fix!

@bshaffer bshaffer changed the title fix: BeforeValidException message for decode chore: BeforeValidException message for decode Jul 14, 2023
@bshaffer bshaffer merged commit 0a53cf2 into main Jul 14, 2023
7 checks passed
@bshaffer bshaffer deleted the differentiate-errors branch July 14, 2023 17:49
@bshaffer bshaffer changed the title chore: BeforeValidException message for decode fix: BeforeValidException message for decode Jul 14, 2023
@release-please release-please bot mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vishwarajanand @bshaffer