Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept float claims but round down to ignore them #492

Merged
merged 2 commits into from Jun 28, 2023

Conversation

croensch
Copy link

@croensch croensch commented Mar 5, 2023

This makes #488 work without having to set leeway.

@google-cla
Copy link

google-cla bot commented Mar 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer
Copy link
Collaborator

bshaffer commented May 23, 2023

Wouldn't it be a better solution to just use microtime(true) instead of time() for the JWT validation?

Update: microtime requires that gettimeofday has an implementation. It seems like this is always the case, but it's possible this library is running on an obscure operating system without an implementation. Maybe we should wait to support microtime in a major version bump

@bshaffer
Copy link
Collaborator

This is a good solution for now, and we can look at using microtime in a future version

@bshaffer bshaffer merged commit 3936842 into firebase:main Jun 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants