JWT::decode: doc-comment for DomainException added #379
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously undocumented. Also fixes doc-comment for InvalidArgumentException. see firebase#312
|
I've already signed the CLA since I noticed the problem here. |
|
@dakujem You just have to reply with a very specific string for Googlebot to look for the CLA again. It's not automatic. |
bshaffer
approved these changes
Dec 1, 2021
|
oh, I was not aware I had to reply somewhere, sorry. |
|
I reran the CLA-bot manually so that you didn't have to ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds previously undocumented
DomainExceptionto the throws list in the doc-comment of theJWT::decodemethod.This hotfixes the issue mentioned in #312 and #378.
See #312 for detailed info.