fix(firebase_remote_config): update exception handling to show actual exception #9629
+31
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/firebase_remote_config/firebase_remote_config/example/android/app/google-services.json # packages/firebase_remote_config/firebase_remote_config/example/android/app/src/main/AndroidManifest.xml # packages/firebase_remote_config/firebase_remote_config/example/macos/Runner.xcodeproj/project.pbxproj
Lyokone
approved these changes
Jan 5, 2023
russellwheatley
force-pushed
the
@russell/remote-config-6196
branch
from
6d91c69 to
7ef3c8d
Compare
…e/android/app/google-services.json
Ehesp
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had to disable Firebase Remote Config API on the GCP console to see the exception.
I have updated Android exception handling to be more descriptive about what the issue is. The exception on Android now logs out:
On iOS, I've caught the exception by checking if it is a forbidden API request (403), and updated so it hints at the issue. New exception message:
Previous, unhelpful exception message:
Both platforms now have the same exception code
forbidden.Related Issues
fixes #7425
This PR is related to #6196 However, there is another exception on that issue thread that I think is unrelated to GCP, the
fetchAndActivate()is being cancelled (Error code-999). Hard to tell without a repro (I've tried some of the ways mentioned in the thread).Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?