feat(ui_storage): add StorageGridView widget #11206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
reviewed
Jul 13, 2023
|
|
||
| SchedulerBinding.instance.addPostFrameCallback((_) async { |
There was a problem hiding this comment.
I always used that as a workaround. Do we have example of addPostCallback being used in official libs?
There was a problem hiding this comment.
not sure why is this a workaround, to me it's a valid usage :)
flutter itself uses it internally
There was a problem hiding this comment.
Thanks, not sure why I always thought it was a "HACK"
Lyokone
approved these changes
Jul 13, 2023
pr-Mais
approved these changes
Jul 13, 2023
russellwheatley
requested changes
Jul 13, 2023
| @@ -0,0 +1,99 @@ | |||
| import 'package:firebase_storage/firebase_storage.dart'; | |||
| @@ -0,0 +1,16 @@ | |||
| import 'package:firebase_ui_shared/firebase_ui_shared.dart'; | |||
russellwheatley
approved these changes
Jul 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #11004
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?