Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core, windows): building improvements #10972

Merged
merged 3 commits into from May 17, 2023
Merged

fix(core, windows): building improvements #10972

merged 3 commits into from May 17, 2023

Conversation

viachaslavic
Copy link
Contributor

@viachaslavic viachaslavic commented May 16, 2023

Description

  1. Fixed paths to SDK libraries depending on the build config.
  2. Using existing SDK on system according desktop-workflow to speed up the build.

Related Issues

fix #10931

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla
Copy link

google-cla bot commented May 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Lyokone
Copy link
Contributor

Lyokone commented May 16, 2023

@viachaslavic thanks a lot for this PR. I'll review this quickly 👍

DESTINATION ${EXTRACTED_PATH})
endif()
set(FIREBASE_CPP_SDK_DIR "${EXTRACTED_PATH}/firebase_cpp_sdk")
if(FIREBASE_SDK_FILE_HASH STREQUAL "3163806e86ca534d417c0306fcf1068acb35dd7545f3ffdaa109f989b2fd411b")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse my ignorance, but is this hash based on the Firebase SDK version? i.e does this need to change every time we change the firebase version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellwheatley, yes. I agree, this is not the most convenient and reliable approach. Instead, I'll try to parse the version from the version header.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellwheatley Done. Now the version is checked natively.

@Lyokone Lyokone merged commit 4897fa0 into firebase:master May 17, 2023
14 of 18 checks passed
@Lyokone
Copy link
Contributor

Lyokone commented May 17, 2023

Thanks a lot for the fix @viachaslavic

@insertjokehere
Copy link

Thanks @viachaslavic!

@viachaslavic viachaslavic deleted the fix/10931 branch June 6, 2023 14:46
@firebase firebase locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_core] Firebase Core 2.11.0 fails to build on Windows
4 participants