feat(auth): move to Pigeon for Platform channels #10802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
changed the title
Lyokone
commented
Apr 20, 2023
...th/firebase_auth_platform_interface/lib/src/method_channel/method_channel_firebase_auth.dart
Show resolved
Hide resolved
Lyokone
commented
Apr 20, 2023
...uth/firebase_auth_platform_interface/lib/src/platform_interface/platform_interface_user.dart
Show resolved
Hide resolved
Lyokone
commented
Apr 21, 2023
...rebase_auth/firebase_auth_platform_interface/lib/src/method_channel/method_channel_user.dart
Show resolved
Hide resolved
Lyokone
commented
May 22, 2023
| @@ -195,7 +195,7 @@ with the Facebook App ID and Secret set. | |||
| } | |||
| ``` | |||
|
|
|||
| Note: Firebase will not set the `User.emailVerified` property | |||
| Note: Firebase will not set the `User.isEmailVerified` property | |||
There was a problem hiding this comment.
.emailVerified is deprecated but still available. It's changed to match Java and the isAnonymous
russellwheatley
requested changes
May 23, 2023
..._auth/android/src/main/java/io/flutter/plugins/firebase/auth/FlutterFirebaseMultiFactor.java
Outdated
Show resolved
Hide resolved
...auth/android/src/main/java/io/flutter/plugins/firebase/auth/IdTokenChannelStreamHandler.java
Show resolved
Hide resolved
packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m
Outdated
Show resolved
Hide resolved
…flutter/plugins/firebase/auth/FlutterFirebaseMultiFactor.java Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
…thPlugin.m Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
russellwheatley
approved these changes
Jun 5, 2023
Salakar
reviewed
Jun 5, 2023
...th/android/src/main/java/io/flutter/plugins/firebase/auth/AuthStateChannelStreamHandler.java
Show resolved
Hide resolved
Salakar
reviewed
Jun 5, 2023
| @@ -34,6 +34,16 @@ Future<void> main() async { | |||
| await auth.useAuthEmulator('localhost', 9099); | |||
| } | |||
|
|
|||
| // Setup | |||
There was a problem hiding this comment.
Should this still be here or is it from testing?
Salakar
reviewed
Jun 5, 2023
Comment on lines
60
to
61
| @"isAnonymous" : @NO, | ||
| @"isEmailVerified" : @YES, |
There was a problem hiding this comment.
Should these 2 BOOLs be hard-coded?
There was a problem hiding this comment.
In Provider Data, the email is always verified and the user is never anonymous. I'm adding a comment
Salakar
reviewed
Jun 5, 2023
Comment on lines
39
to
51
| @Deprecated('Use isEmailVerified instead') | ||
| bool get emailVerified { | ||
| return _delegate.emailVerified; | ||
| return _delegate.isEmailVerified; | ||
| } | ||
|
|
||
| /// Returns whether the users email address has been verified. | ||
| /// | ||
| /// To send a verification email, see [sendEmailVerification]. | ||
| /// | ||
| /// Once verified, call [reload] to ensure the latest user information is | ||
| /// retrieved from Firebase. | ||
| bool get isEmailVerified { | ||
| return _delegate.isEmailVerified; |
There was a problem hiding this comment.
To match the underlying API and the isAnonymous API (felt weird to have a is api and anoter one without it even if both API are returning a bool, I can do it in another PR)
Salakar
approved these changes
Jul 10, 2023
cynthiajoan
reviewed
Jul 14, 2023
| @@ -26,7 +26,7 @@ on: | |||
|
|
|||
| jobs: | |||
| android: | |||
| runs-on: macos-13 | |||
| runs-on: macos-13-xl | |||
There was a problem hiding this comment.
What's the reason to upgrade to large runners? Seems in all other places we are using standard runner.
This was referenced Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving Auth to Pigeon to prepare for Windows C++ port.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?