Add no-undeclared-imports eslint rule #8017
Merged
+45
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Broke the build, will resend once i fix that. |
bkendall
approved these changes
Dec 4, 2024
mathu97
approved these changes
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8017 +/- ##
==========================================
- Coverage 51.19% 51.15% -0.05%
==========================================
Files 423 423
Lines 29544 29577 +33
Branches 6031 6040 +9
==========================================
+ Hits 15125 15130 +5
- Misses 13059 13087 +28
Partials 1360 1360 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add no-undeclared-imports eslint rule - this means importing something not declared in package.json (like an indirect dependency) will be a linter error.
This also caught a few cases of us using types from indirect dependencies - this isn't a runtime error (since types get washed away during compile), but it is ugly, so I added those as devDeps.