Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to fix issues-4170 #7980

Merged
merged 12 commits into from
Dec 4, 2024
Merged

Updated to fix issues-4170 #7980

merged 12 commits into from
Dec 4, 2024

Conversation

mohankumarelec
Copy link
Contributor

Description

Closes: #4170
This PR fixes the issue and adds feature of linkProviderUserInfo in auth emulator.

Scenarios Tested

  • should error if linkProviderUserInfo is missing required fields
  • should error if user is disabled when linking a provider

@joehan
Copy link
Contributor

joehan commented Nov 21, 2024

Note: Needs a CHANGELOG entry before merge.

@yuchenshi
Copy link
Member

PTAL at the unit test failures and I can do another round of review after

@yuchenshi
Copy link
Member

I think we're just missing one entry to CHANGELOG.md as Joe said, and then we're ready to merge as soon as the CI completes.

Copy link
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertion conditions seems flipped, which breaks unit tests. Please see suggested fixes. Please also add a CHANGELOG entry.

CI failure: https://github.com/firebase/firebase-tools/actions/runs/12128407551/job/33814720138?pr=7980#step:6:4129

mohankumarelec and others added 3 commits December 4, 2024 17:55
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
@yuchenshi yuchenshi enabled auto-merge (squash) December 4, 2024 23:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.14%. Comparing base (e895fd2) to head (13549f5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7980   +/-   ##
=======================================
  Coverage   51.14%   51.14%           
=======================================
  Files         423      423           
  Lines       29581    29585    +4     
  Branches     6043     6045    +2     
=======================================
+ Hits        15128    15132    +4     
  Misses      13094    13094           
  Partials     1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan disabled auto-merge December 4, 2024 23:29
@joehan joehan merged commit 6b107c9 into firebase:master Dec 4, 2024
12 of 13 checks passed
@yuchenshi
Copy link
Member

This has been released in Firebase CLI v13.28.0. @mohankumarelec Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to add/link new provider to the account results in 501
4 participants