-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to fix issues-4170 #7980
Conversation
Note: Needs a CHANGELOG entry before merge. |
PTAL at the unit test failures and I can do another round of review after |
I think we're just missing one entry to CHANGELOG.md as Joe said, and then we're ready to merge as soon as the CI completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion conditions seems flipped, which breaks unit tests. Please see suggested fixes. Please also add a CHANGELOG entry.
CI failure: https://github.com/firebase/firebase-tools/actions/runs/12128407551/job/33814720138?pr=7980#step:6:4129
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Co-authored-by: Yuchen Shi <yuchenshi@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7980 +/- ##
=======================================
Coverage 51.14% 51.14%
=======================================
Files 423 423
Lines 29581 29585 +4
Branches 6043 6045 +2
=======================================
+ Hits 15128 15132 +4
Misses 13094 13094
Partials 1359 1359 ☔ View full report in Codecov by Sentry. |
This has been released in Firebase CLI v13.28.0. @mohankumarelec Thanks for the contribution! |
Description
Closes: #4170
This PR fixes the issue and adds feature of
linkProviderUserInfo
in auth emulator.Scenarios Tested