Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update sharp version #7517

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Conversation

emwp
Copy link
Contributor

@emwp emwp commented Aug 1, 2024

Description

Updating sharp version to address issue related on issue: #7346
Sharp version needs to be updated in two places, there is already a PR on the other repo:
FirebaseExtended/firebase-framework-tools#227

Scenarios Tested

Ran tests locally for Next.js 12 to 14 and Angular 14 to 17.
Also running locally with the updated sharp version from this PR: FirebaseExtended/firebase-framework-tools#227 for firebase-framework.

Sample Commands

N/A

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

google-cla bot commented Aug 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@leoortizz leoortizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just add changelog then we can merge. Thanks!

@emwp
Copy link
Contributor Author

emwp commented Aug 3, 2024

LGTM! Just add changelog then we can merge. Thanks!

Done!

emwp and others added 2 commits August 5, 2024 10:48
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
@leoortizz leoortizz enabled auto-merge (squash) August 5, 2024 15:10
auto-merge was automatically disabled August 6, 2024 13:40

Head branch was pushed to by a user without write access

emwp and others added 3 commits August 6, 2024 10:40
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
@leoortizz leoortizz enabled auto-merge (squash) August 6, 2024 21:40
@leoortizz leoortizz merged commit 7513b27 into firebase:master Aug 6, 2024
38 checks passed
@emwp emwp deleted the update-sharp-version branch August 11, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants