-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update sharp version #7517
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just add changelog then we can merge. Thanks!
… into update-sharp-version
Done! |
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Head branch was pushed to by a user without write access
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Description
Updating sharp version to address issue related on issue: #7346
Sharp version needs to be updated in two places, there is already a PR on the other repo:
FirebaseExtended/firebase-framework-tools#227
Scenarios Tested
Ran tests locally for Next.js 12 to 14 and Angular 14 to 17.
Also running locally with the updated sharp version from this PR: FirebaseExtended/firebase-framework-tools#227 for firebase-framework.
Sample Commands
N/A