Refactor: extract template helpers into templates.ts #7361
Merged
+129
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
yuchenshi
commented
Jun 21, 2024
| | `src/test` | Contains test helpers. Actual tests (`*.spec.ts`) should be colocated with source files. | | ||
| | `templates` | Contains static files needed for various reasons (init templates, login success HTML, etc.) | |
There was a problem hiding this comment.
This is a mere correction to the documentation. No files are actually moved.
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
hlshen
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes template file paths all relative to
/templates/and removes a lot of__dirnameusages.It allows source files to be moved around using TypeScript refactoring without breaking template paths.
Note that unlike #7332, moving template files themselves still requires manually updating string literals. (I've considered adding manifest files to templates but gave up since
/templatesare not in/src.)Scenarios Tested
See integration tests. Not every change is covered by tests though -- we may have to rely on careful code reviews on others.
Sample Commands
N/A