Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added permissions for GitHub workflow config #6791

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Added permissions for GitHub workflow config #6791

merged 3 commits into from
Feb 21, 2024

Conversation

aalej
Copy link
Contributor

@aalej aalej commented Feb 20, 2024

Description

Fixes #6789

Issue above describes that there are missing permissions when a GitHub action workflow is triggered. See this Stack Overflow post. Adding the permissions in the yaml file should resolve the issue.

Scenarios Tested

  1. Run firebase init hosting --project <project_id>
    • Yes to all defaults
  2. Run firebase init hosting:github
    • Log in to GitHub
    • Enter your GitHub repository
    • Select all defaults
  3. Push to the repository
git init
git add .
git commit -m "first commit"
git branch -M main
git remote add origin https://github.com/<repo>
git push -u origin main
  1. Create a new PR. Do the ff:
    • Run git branch some-branch
    • Run git switch some-branch
    • Make changes to some files
    • Push the changes to a remote branch:
git add .
git commit -m "some branch changes"
git push origin some-branch
  1. Submit the PR
    • “Deploy to Firebase Hosting on PR / build_and_preview (pull_request)” should be successful

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09c2641) 54.30% compared to head (65a5658) 54.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6791   +/-   ##
=======================================
  Coverage   54.30%   54.30%           
=======================================
  Files         350      350           
  Lines       24301    24301           
  Branches     5029     5029           
=======================================
  Hits        13196    13196           
  Misses       9899     9899           
  Partials     1206     1206           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkendall bkendall enabled auto-merge (squash) February 21, 2024 19:28
@bkendall bkendall merged commit 38d119b into master Feb 21, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub actions automatic deploying pull requests to preview channels errors
3 participants