-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FAH onboarding flow to connect backends with SCMs #6764
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6764 +/- ##
==========================================
- Coverage 54.31% 54.31% -0.01%
==========================================
Files 349 349
Lines 24283 24312 +29
Branches 5021 5026 +5
==========================================
+ Hits 13190 13204 +14
- Misses 9888 9902 +14
- Partials 1205 1206 +1 ☔ View full report in Codecov by Sentry. |
src/gcp/cloudbuild.ts
Outdated
const res = await client.get<LinkableRepositories>(name); | ||
const res = await client.get<LinkableRepositories>(name, { | ||
queryParams: { | ||
pageSize: 20, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider passing this in by arg as well. We may as well request a page size of 1000 if we're trying to fetch all repos
src/init/features/apphosting/repo.ts
Outdated
@@ -226,6 +257,9 @@ async function promptAppInstall(conn: gcb.Connection): Promise<gcb.Connection> { | |||
return await gcb.getConnection(projectId, location, id); | |||
} | |||
|
|||
/** | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing doc string?
This PR fixes a number of different issues with connecting repos to FAH backends: