FAH bugfixes #6754
Merged
FAH bugfixes #6754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
inlined
commented
Feb 8, 2024
inlined
commented
- Fixes issue where the --branch param on builds:create is ignored
- Fixes issue where the build ID uses day of week instead of day of month
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6754 +/- ##
=======================================
Coverage 54.31% 54.31%
=======================================
Files 349 349
Lines 24283 24283
Branches 5021 5021
=======================================
Hits 13190 13190
Misses 9888 9888
Partials 1205 1205 ☔ View full report in Codecov by Sentry. |
bkendall
approved these changes
Feb 9, 2024
| @@ -16,12 +16,12 @@ export const command = new Command("apphosting:builds:create <backendId>") | |||
| const buildId = | |||
| (options.buildId as string) || | |||
| (await apphosting.getNextRolloutId(projectId, location, backendId)); | |||
| const branch = options.branch as string; | |||
| const branch = (options.branch as string | undefined) ?? "main"; | |||
There was a problem hiding this comment.
A really neat improvement to this would be to see if they have a RolloutPolicy and pull the "default" branch from there. But that can come later.
There was a problem hiding this comment.
File a bug and assign it to me. I agree that would be much better, but IIRC rollouts is still an "internal tool" that hasn't gone through API review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.