Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent hosting API calls when using JS SDK with frameworks and demo project on emulators #6737

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

leoortizz
Copy link
Member

Description

Fixes #6377

Scenarios Tested

Sample Commands

...with frameworks and demo project on emulators
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.22%. Comparing base (41922fe) to head (14bd1e6).

Files Patch % Lines
src/frameworks/index.ts 33.33% 4 Missing ⚠️
src/hosting/api.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6737      +/-   ##
==========================================
- Coverage   54.22%   54.22%   -0.01%     
==========================================
  Files         352      352              
  Lines       24488    24494       +6     
  Branches     5065     5067       +2     
==========================================
+ Hits        13278    13281       +3     
- Misses       9997    10000       +3     
  Partials     1213     1213              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesdaniels
Copy link
Member

Add changelog, otherwise LGTM

@leoortizz leoortizz enabled auto-merge (squash) February 28, 2024 17:56
@leoortizz leoortizz merged commit 1fb1382 into master Feb 28, 2024
34 of 35 checks passed
@leoortizz leoortizz deleted the leoortizz_fixDemoProjectWithFrameworks branch March 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulator doesn't work with demo projects + web frameworks
3 participants