New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for automated tests in App Distribution #6730
Conversation
6a98dca
to
fd4fe15
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6730 +/- ##
===========================================
+ Coverage 0 54.21% +54.21%
===========================================
Files 0 349 +349
Lines 0 24247 +24247
Branches 0 5010 +5010
===========================================
+ Hits 0 13146 +13146
- Misses 0 9899 +9899
- Partials 0 1202 +1202 ☔ View full report in Codecov by Sentry. |
31df542
to
bbea92c
Compare
e6d5ee1
to
cd4c845
Compare
9bed02b
to
6fb713f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code mostly looks good, with a few small style fixes suggested. However, this change needs an approved API proposal since it changes that public API of the CLI. I have some concerns about the API for this command that would be better discussed there. I couldn't find one at go/firebase-api-tracker - could you link one if I missed it, or start one up?
2df6e0b
to
9469c64
Compare
ee32d10
to
c1f6d9e
Compare
Description
Adding
--test-devices
and related flags toappdistribution:distribute
action. This will trigger the new Automated Tester feature.Scenarios Tested
Sample Commands
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices>
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-async
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password>
firebase appdistribution:distribute --app <app id> <path> --test-devices <devices> --test-username <user> --test-password <password> --test-username-resource <resource id> --test-password-resource <resource id>