Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5561 emulators not starting with vite #6411

Closed
wants to merge 2 commits into from

Conversation

sotovviktor
Copy link
Contributor

Description

Fixes #5561

stdout data on widnows has ANSI characters in the URL preventing resolution of the promise. This PR fixes it.

@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (25a7239) 54.65% compared to head (a75add6) 54.65%.
Report is 10 commits behind head on master.

Files Patch % Lines
src/frameworks/vite/index.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6411      +/-   ##
==========================================
- Coverage   54.65%   54.65%   -0.01%     
==========================================
  Files         347      347              
  Lines       23801    23803       +2     
  Branches     4893     4893              
==========================================
+ Hits        13009    13010       +1     
- Misses       9595     9596       +1     
  Partials     1197     1197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add changelog entry and see about converting to an import statement and g2g

src/frameworks/vite/index.ts Show resolved Hide resolved
@jamesdaniels
Copy link
Member

I addressed feedback in #6588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emulators not starting properly when emulating hosting on a vite project
3 participants