Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow secrets to be set before deploying functions #5918

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

inlined
Copy link
Member

@inlined inlined commented May 31, 2023

Addressing old feedback I got in person at the Firebase Summit since it seems it never got picked up. Customers sometimes want to set a secret when they set up a new project, but the command fails until they try to deploy broken functions first.

The alternative solution, of course, is to declare a secret param, but this seems like a friendly guardrail given that the command exists.

@inlined inlined requested a review from taeold May 31, 2023 23:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023

Codecov Report

Patch coverage: 60.00% and no project coverage change.

Comparison is base (ac467a1) 54.98% compared to head (612dc68) 54.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5918   +/-   ##
=======================================
  Coverage   54.98%   54.98%           
=======================================
  Files         333      333           
  Lines       22985    22990    +5     
  Branches     4710     4710           
=======================================
+ Hits        12639    12642    +3     
- Misses       9217     9219    +2     
  Partials     1129     1129           
Impacted Files Coverage Δ
src/functions/secrets.ts 82.17% <60.00%> (-0.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@inlined inlined merged commit e0d0b1b into master Jun 2, 2023
30 of 31 checks passed
@inlined inlined deleted the inlined.secrets-init branch June 2, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants