Improves cleanup process when reloading emulated functions in debug mode. #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5878 +/- ##
==========================================
- Coverage 54.97% 54.97% -0.01%
==========================================
Files 333 333
Lines 22980 22982 +2
Branches 4711 4712 +1
==========================================
Hits 12634 12634
- Misses 9218 9220 +2
Partials 1128 1128
☔ View full report in Codecov by Sentry. |
colerogers
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of spawning a new process that exposes the debugger endpoint, the Functions Emulator will attempt to explicitly kill the existing process before loading the function with the updated source code.
Possible fix for #5508, #5653