Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log lines to clarify what pinning is doing #5787

Merged
merged 5 commits into from
May 3, 2023
Merged

Conversation

inlined
Copy link
Member

@inlined inlined commented May 3, 2023

Per bug bash feedback, this adds logs for:

  1. Explaining that pinned functions will also be deployed even if there is an --only string that does not include them
  2. Explaining that run pins target the current latest revision of the Run service since we cannot deploy them with the CLI.=

@inlined inlined requested a review from jamesdaniels May 3, 2023 15:43
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Patch coverage: 71.42% and no project coverage change.

Comparison is base (4d6da7e) 55.19% compared to head (14ba0d2) 55.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5787   +/-   ##
=======================================
  Coverage   55.19%   55.20%           
=======================================
  Files         329      329           
  Lines       22527    22537   +10     
  Branches     4590     4593    +3     
=======================================
+ Hits        12434    12441    +7     
  Misses       8989     8989           
- Partials     1104     1107    +3     
Impacted Files Coverage Δ
src/deploy/hosting/prepare.ts 65.30% <71.42%> (+0.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joehan joehan enabled auto-merge (squash) May 3, 2023 17:49
@joehan joehan merged commit 25613a6 into master May 3, 2023
33 of 34 checks passed
@joehan joehan deleted the inlined.pinning-logs branch May 3, 2023 18:15
ProfHercules pushed a commit to ProfHercules/firebase-tools that referenced this pull request May 5, 2023
Co-authored-by: joehan <joehanley@google.com>
tonyjhuang pushed a commit that referenced this pull request May 22, 2023
Co-authored-by: joehan <joehanley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants