NextJS 13.3 app directory & frameworks CTA #5691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
commented
Apr 14, 2023
jamesdaniels
commented
Apr 14, 2023
jamesdaniels
commented
Apr 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
=======================================
Coverage 55.21% 55.21%
=======================================
Files 327 328 +1
Lines 22326 22400 +74
Branches 4561 4570 +9
=======================================
+ Hits 12327 12368 +41
- Misses 8904 8933 +29
- Partials 1095 1099 +4
☔ View full report in Codecov by Sentry. |
jamesdaniels
commented
Apr 28, 2023
| if (!isNextImageImported && isUsingAppDirectory(dir)) { | ||
| isNextImageImported = (await readFile(join(dir, "server", "client-reference-manifest.js"))) | ||
| .toString() | ||
| .includes("node_modules/next/dist/client/image.js"); |
There was a problem hiding this comment.
TODO be smarter about this, should we read the json, require.resolve the client name?
* add static API to Next.js test app * use `emulators:exec 'exit 0'` instead of `deploy` * add `test:webframeworks-deploy` script to GH action * temporarily disable `needs: unit` * `..env.FBTOOLS_TARGET_PROJECT` for FIREBASE_PROJECT * source scripts/set-default-credentials.sh * pass "exit 0" as arg to the CLI * adjust tests to match project * rename test case * remove log * util to get build id * test static files * Revert "temporarily disable `needs: unit`" This reverts commit b9eb90a. * restore experiment flag * Rework expected files * Boolean fixes --------- Co-authored-by: James Daniels <jamesdaniels@google.com>
jamesdaniels
added a commit
that referenced
this pull request
May 2, 2023
jamesdaniels
added a commit
that referenced
this pull request
May 2, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
* Handle Next 13 app directory—fixes firebase#5661, firebase#5522 * Actually pull static assets from app directory now that it's stabilizing, fixes firebase#5660 * Hack for detecting image optimization in app directory * Add frameworks CTA * Add integration test for frameworks back in * Add timeouts to NPM and bundle commands—fixes firebase#5661, firebase#5622 --------- Co-authored-by: Leonardo Ortiz <leo@monogram.io>
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
* Handle Next 13 app directory—fixes #5661, #5522 * Actually pull static assets from app directory now that it's stabilizing, fixes #5660 * Hack for detecting image optimization in app directory * Add frameworks CTA * Add integration test for frameworks back in * Add timeouts to NPM and bundle commands—fixes #5661, #5622 --------- Co-authored-by: Leonardo Ortiz <leo@monogram.io>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next 13.3 app directory changed in a couple important ways:
This broke our integration, see #5661
While I'm mucking around in here: