Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift GCF 2nd gen naming restrictions #5690

Merged
merged 4 commits into from
Apr 20, 2023
Merged

Lift GCF 2nd gen naming restrictions #5690

merged 4 commits into from
Apr 20, 2023

Conversation

inlined
Copy link
Member

@inlined inlined commented Apr 13, 2023 •
edited by taeold

🎉

Fixes #5695

@inlined inlined requested a review from Berlioz April 13, 2023 19:04
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (18c03e7) 55.60% compared to head (90c10e9) 55.59%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5690      +/-   ##
==========================================
- Coverage   55.60%   55.59%   -0.02%     
==========================================
  Files         324      324              
  Lines       21980    21973       -7     
  Branches     4480     4477       -3     
==========================================
- Hits        12222    12215       -7     
  Misses       8678     8678              
  Partials     1080     1080
Impacted Files Coverage Δ
src/deploy/functions/validate.ts 96.47% <100.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@inlined inlined marked this pull request as ready for review April 13, 2023 21:58
@joehan joehan mentioned this pull request Apr 18, 2023
Closed
@taeold taeold enabled auto-merge (squash) April 20, 2023 19:14
@taeold taeold merged commit 7910bb2 into master Apr 20, 2023
32 of 33 checks passed
@cbenhagen cbenhagen mentioned this pull request May 4, 2023
Closed
ProfHercules pushed a commit to ProfHercules/firebase-tools that referenced this pull request May 5, 2023
@inlined @ProfHercules
Lift GCF 2nd gen naming restrictions (firebase#5690)
0e0ac0c 
Fixes firebase#5695
tonyjhuang pushed a commit that referenced this pull request May 22, 2023
@inlined @tonyjhuang
Lift GCF 2nd gen naming restrictions (#5690)
b2d995e 
Fixes #5695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taeold taeold taeold approved these changes

@Berlioz Berlioz Awaiting requested review from Berlioz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functions v2 named using uppercase letters are not deployed
3 participants
@inlined @codecov-commenter @taeold