Prevent GCF from automatically running the build script. #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronDev
approved these changes
Apr 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5687 +/- ##
==========================================
- Coverage 55.73% 55.72% -0.02%
==========================================
Files 322 322
Lines 21830 21836 +6
Branches 4454 4454
==========================================
Hits 12168 12168
- Misses 8594 8600 +6
Partials 1068 1068
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
colerogers
approved these changes
Apr 13, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
GCF will now run `npm run build` script as part of function deploys: https://cloud.google.com/functions/docs/release-notes#April_11_2023 This is a breaking change. We want to shield Cloud Functions for Firebase user from the breaking change and manually disable the behavior in CF3 deploys. We will enable the GCF feature in the next major CLI release.
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
GCF will now run `npm run build` script as part of function deploys: https://cloud.google.com/functions/docs/release-notes#April_11_2023 This is a breaking change. We want to shield Cloud Functions for Firebase user from the breaking change and manually disable the behavior in CF3 deploys. We will enable the GCF feature in the next major CLI release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCF will now run
npm run buildscript as part of function deploys:https://cloud.google.com/functions/docs/release-notes#April_11_2023
This is a breaking change. We want to shield Cloud Functions for Firebase user from the breaking change and manually disable the behavior in CF3 deploys. We will enable the GCF feature in the next major CLI release.