Fix broken Functions CLI experience for projects with incomplete GCF 2nd Gen functions. #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice breaks the Functions CLI experience. The codebase assumes that "serviceConfig" property must be present in all 2nd Gen Functions in GCF. This isn't the case - 2nd Gen GCF functions may be missing a Cloud Run service if the build never succeeded.
taeold
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5684 +/- ##
==========================================
- Coverage 55.71% 55.67% -0.04%
==========================================
Files 322 322
Lines 21836 21846 +10
Branches 4454 4461 +7
==========================================
- Hits 12166 12163 -3
- Misses 8602 8608 +6
- Partials 1068 1075 +7
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TheIronDev
reviewed
Apr 13, 2023
TheIronDev
approved these changes
Apr 13, 2023
inlined
reviewed
Apr 13, 2023
| * type Bar = RequireKeys<Foo, "a" | "b"> | ||
| * // Property "a" and "b" are now required. | ||
| */ | ||
| export type RequireKeys<T extends object, Keys extends keyof T> = T & { |
There was a problem hiding this comment.
Would you like me to make a DeepRequire like we have DeepOmit and DeepPick? Then you can say DeepRequire<Foo, "a.b" | "c">
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
…2nd Gen functions. (firebase#5684) The codebase assumes that "serviceConfig" property must be present in all 2nd Gen Functions in GCF. This is an incorrect assumption - 2nd Gen GCF functions may be missing a Cloud Run service if the build never succeeded. Also refactors `backend` module a bit to avoid calling out to Cloud Run to retrieve concurrency & cpu config - it's available on the GCF response now! Fixes firebase#4800
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
…2nd Gen functions. (#5684) The codebase assumes that "serviceConfig" property must be present in all 2nd Gen Functions in GCF. This is an incorrect assumption - 2nd Gen GCF functions may be missing a Cloud Run service if the build never succeeded. Also refactors `backend` module a bit to avoid calling out to Cloud Run to retrieve concurrency & cpu config - it's available on the GCF response now! Fixes #4800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase assumes that "serviceConfig" property must be present in all 2nd Gen Functions in GCF. This is an incorrect assumption - 2nd Gen GCF functions may be missing a Cloud Run service if the build never succeeded.
Also refactors
backendmodule a bit to avoid calling out to Cloud Run to retrieve concurrency & cpu config - it's available on the GCF response now!Fixes #4800